Ignore a material definition if a game overrides a texture #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it expected that
|
|
Oops 🙈 Should work after the last commit... |
…is identical to baseq2
Handled by material system now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games override baseq2 assets without changing the name -
e.g. 'action' replaces models/weapons/v_blast with something looking completely differently.
Using the material definition from baseq2 makes things look wrong.
So try to detect if the game is overriding a texture from baseq2 and, if that is the case, ignore the material definition (if it's from baseq2 - to allow for a game-specific material definition).
(I previously submitted something with the same intent as part of #116 [2415da2], but it seems those changes got lost or ineffective during the material system overhaul.)