Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openal-soft to 1.23.1 #395

Closed
wants to merge 3 commits into from

Conversation

runlevel5
Copy link
Contributor

@runlevel5 runlevel5 commented Mar 27, 2024

TODO

  • Addresses all warnings

@apanteleev
Copy link
Collaborator

Getting many new warnings with the new version: overriding '/W3' with '/W4' for every OAL file, also implicit type conversions from size_t to int and double to float. I'd avoid updating to this version unless it brings noticeable fixes or improvements.

@runlevel5
Copy link
Contributor Author

Getting many new warnings with the new version: overriding '/W3' with '/W4' for every OAL file, also implicit type conversions from size_t to int and double to float. I'd avoid updating to this version unless it brings noticeable fixes or improvements.

Fair call. I would prefer to keep it up to date to make things easier for downstream packager. How about I address all of the warnings first then we could revisit this PR?

@runlevel5 runlevel5 marked this pull request as draft April 2, 2024 00:25
@apanteleev
Copy link
Collaborator

How about I address all of the warnings first then we could revisit this PR?

Sounds good.

@runlevel5 runlevel5 closed this May 1, 2024
@runlevel5 runlevel5 deleted the openal-soft-1-23-1 branch May 1, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants