Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np bool issue #2557

Closed
joihn opened this issue Dec 20, 2022 · 13 comments
Closed

np bool issue #2557

joihn opened this issue Dec 20, 2022 · 13 comments
Assignees
Labels
triaged Issue has been triaged by maintainers

Comments

@joihn
Copy link

joihn commented Dec 20, 2022

np.bool support was dropped on numpy 1.24.0
numpy/numpy#22607

Thus, this line now raise an error:
https://github.com/NVIDIA/TensorRT/blob/main/python/packaging/tensorrt/__init__.py#L166

@zerollzeng
Copy link
Collaborator

zerollzeng commented Dec 20, 2022

It's been fixed internally, thanks for reporting this.

Just change the line to bool: np.bool_, if you are using the 1.24 version.

@zerollzeng zerollzeng self-assigned this Dec 20, 2022
@zerollzeng zerollzeng added the triaged Issue has been triaged by maintainers label Dec 20, 2022
@tvalentyn
Copy link

When do you anticipate to have a release that fixes this? Thanks!

@zerollzeng
Copy link
Collaborator

In the next release, but I'm not sure about the date.

@tvalentyn
Copy link

tvalentyn commented Dec 20, 2022

thanks so much, just so I understand, are we talking about days, weeks or longer than that?
We depend on tensorrt in apache-beam, but I can patch this up in beam, if the tensorrt release is not on the horizon yet.
cc: @azhurkevich fyi.

@tvalentyn
Copy link

Friendly ping - do we have a guesstimate when a fix may be released? looks like this surfaced in several other linked issues.

@azhurkevich
Copy link
Contributor

@zerollzeng

@zerollzeng
Copy link
Collaborator

The fix will be in TRT 8.6 release, but I don't have the ETA of release now.

A quick WAR for this issue is to use Numpy <= 1.23.

@ttyio
Copy link
Collaborator

ttyio commented Mar 1, 2023

Closing since no activity for more than 3 weeks, please reopen if you still have question, thanks!

@ttyio ttyio closed this as completed Mar 1, 2023
@tvalentyn
Copy link

tvalentyn commented Mar 1, 2023

Can you comment on this release please: https://pypi.org/project/nvidia-tensorrt/99.0.0/ .

  1. Does it include the fix?
  2. Is the versioning done as intended?

@tvalentyn
Copy link

Unfortunately I can't reopen the issue.

@azhurkevich
Copy link
Contributor

azhurkevich commented Mar 1, 2023

@zerollzeng @ttyio

@braindevices
Copy link

Can you comment on this release please: https://pypi.org/project/nvidia-tensorrt/99.0.0/ .

1. Does it include the fix?

2. Is the versioning done as intended?

problem remains

@zerollzeng
Copy link
Collaborator

I think the fix will be available in 8.6 EA, which should be coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

6 participants