Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samurdhikaru @johnnynunez
Continuing the discussion initiated in PR #3859
I removed the YoloNMS plugin and created a new plugin named EfficientNMSX (with 'X' representing the index) within the structure of the EfficientNMSPlugin. The changes involved creating a new plugin using the current index generation logic and simply adding a new layer that returns detection indices.
Since the changes were minimal, I did not implement the IPluginV3 interface, as that would have required a complete overhaul of the entire plugin structure.
I conducted all tests on both the EfficientNMS_TRT and EfficientNMSX_TRT plugins, and both functioned correctly.
I would appreciate your suggestion regarding the IPluginV3 implementation. Should we update the entire EfficientNMSPlugin now, or should we continue with the current approach and make the switch to IPluginV3 all at once during a future upgrade?
Theses changes also was implemented on release/8.6 ( only for test purposes)
https://github.com/levipereira/TensorRT/tree/release/8.6