Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix bug when selecting tuned RMSNorm kernels #983

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

timmoon10
Copy link
Collaborator

Description

#886 introduced a bug by checking the wrong unordered_map when deciding whether to use a tuned RMSNorm kernel. See #941 (comment).

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Fix bug from checking wrong unordered_map when deciding to whether to use tuned RMSNorm kernel

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added the bug Something isn't working label Jul 2, 2024
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@Oleg-Goncharov
Copy link
Collaborator

LGTM

@timmoon10 timmoon10 merged commit 7669bf3 into NVIDIA:main Jul 2, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants