move previous fused_adam and fp16_optimizer to contrib #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarilli
reviewed
Oct 3, 2019
mcarilli
reviewed
Oct 3, 2019
mcarilli
reviewed
Oct 3, 2019
|
is this somehow a workaround to #475 ? |
We are adding this code path to help investigate the issue and we don't recommend switching back to this deprecated path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add back old fused_adam to contrib, which handle type casting, unscaling and clipping
move fp16_optimizer wrapper with it, which handle flattening, nan ckecking and loss scaling
User should be advised to use AMP with optimizers in apex.optimizers.