Add cuda::ptx::st_async
#1078
Merged
Add cuda::ptx::st_async
#1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the size can be either 32 or 64 bit, this can catch a lot of errors. For instance: uint64_t * remote_buffer; uint64_t * remote_bar; cuda::ptx::st_async(remote_buffer, 1, remote_bar); would previously use the .b32 path because the `1` is an integer and determines the type resolution. Now, this will result in a compiler error. Resolution is to either (a) change the value type, or (b) change the buffer type. a) uint64_t * remote_buffer; cuda::ptx::st_async(remote_buffer, uint64_t(1), remote_bar); b) int32_t * remote_buffer; cuda::ptx::st_async(remote_buffer, 1, remote_bar);
The type may be misleading on this one, so I added a note on alignment of the destination address.
ahendriksen
requested review from
griwes and
elstehle
and removed request for
a team
1 task
miscco
approved these changes
Nov 10, 2023
jrhemstad
added
the
backport branch/2.3.x
|
Successfully created backport PR for |
jrhemstad
removed
the
backport branch/2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1077
Checklist