Introduce CUB transform reduce #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
requested review from
elstehle and
griwes
and removed request for
a team
griwes
approved these changes
Nov 15, 2023
|
Q: Would it make sense to also offer a block-level TransformReduce? I wonder if it could help reduce register usage? |
I think this is a good idea! @leofang could you please file an issue with this request so we can prioritize it? |
1 task
|
Yup done 🙂 #1121 |
gevtushenko
force-pushed
the
enh-main/github/transform_reduce
branch
from
b4ba1ac
to
0ab0966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #435
This PR introduces
cub::DeviceReduce::TransformReduce. Compared to using transform iterator withcub::DeviceReduce::Reduce, transform reduce preserves vectorized loads, providing about 10% perf improvement onstd::uint8_t. This PR doesn't lead to any SASS differences incub::DeviceReduce::Reduce. PR also utilizes newcub::DeviceReduce::TransformReducein Thrust.Checklist