Fix config when only non-CDPv1 arches are enabled. #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
requested review from
wmaxey and
elstehle
and removed request for
a team
alliepiper
force-pushed
the
check_rdc_arch_list_for_cdp_targets
branch
from
c91fa4f
to
18c6031
Compare
Allows things like `ci/build_cub.sh -arch 90` to work as-expected. Fixes NVIDIA#219.
alliepiper
force-pushed
the
check_rdc_arch_list_for_cdp_targets
branch
from
18c6031
to
4a1e64f
Compare
miscco
approved these changes
Nov 15, 2023
griwes
approved these changes
Nov 15, 2023
elstehle
approved these changes
Nov 15, 2023
|
Can this be backported to branch/2.3.x? |
wmaxey
added
the
backport branch/2.3.x
|
/backport |
|
Successfully created backport PR for |
miscco
added
backport done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows things like
ci/build_cub.sh -arch 90to work as-expected.Fixes #219,
Description
Adds logic to skip adding RDC targets when the RDC arch list is empty.