Prepare more algorithms #1161
Merged
Prepare more algorithms #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gevtushenko I know you will ask about enhancing standard algorithms to use invoke. I did not do it here, but we can discuss this as a general guideline going forward |
miscco
force-pushed
the
more_algorithms
branch
4 times, most recently
from
91c3501
to
6166120
Compare
gevtushenko
reviewed
Dec 8, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__algorithm/copy.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__algorithm/copy.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__algorithm/copy_backward.h
Outdated
Show resolved
Hide resolved
miscco
force-pushed
the
more_algorithms
branch
from
6166120
to
470dde8
Compare
jrhemstad
reviewed
Dec 11, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__algorithm/copy.h
Outdated
Show resolved
Hide resolved
miscco
force-pushed
the
more_algorithms
branch
2 times, most recently
from
adc0ee9
to
d2d4e7c
Compare
gevtushenko
reviewed
Dec 11, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__algorithm/move.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__algorithm/move_backward.h
Outdated
Show resolved
Hide resolved
miscco
force-pushed
the
more_algorithms
branch
2 times, most recently
from
a216435
to
f69ced9
Compare
miscco
force-pushed
the
more_algorithms
branch
from
f69ced9
to
ae67f94
Compare
gevtushenko
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves more of the algorithms into their own files and makes them available internally
Note that I did not move to upstreams improved copy implementation as that will need to thoughts in the heterogeneous setup