Add first batch of Catch2 tests for DeviceRadixSort #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All were overflowing to NaN when casting min/max to float.
Adds a matcher that treats `NaN == NaN`, and a bitwise matcher to allow testing for stability when sorting pos/neg zeros.
Also encapsulates memory handling in member functions.
The filtered type lists are now hardcoded as a WAR. Also removed the warning suppression for the unused var in catch2, as local windows builds did not respect the pragma. Now we just hardcode whether FP types are available for each key pass and disable the relevant tests as needed.
gevtushenko
approved these changes
Dec 1, 2023
Comment on lines
160
to
161
| const int begin_bit = GENERATE_COPY(0, 1, num_bits / 3, 3 * num_bits / 4, num_bits); | ||
| const int end_bit = GENERATE_COPY(0, 1, num_bits / 3, 3 * num_bits / 4, num_bits); |
There was a problem hiding this comment.
suggestion: same motivation as with num_items:
Suggested change
| const int begin_bit = GENERATE_COPY(0, 1, num_bits / 3, 3 * num_bits / 4, num_bits); | |
| const int end_bit = GENERATE_COPY(0, 1, num_bits / 3, 3 * num_bits / 4, num_bits); | |
| const int begin_bit = GENERATE_COPY(take(2, random(0, num_bits))); | |
| const int end_bit = GENERATE_COPY(take(2, random(begin_bit, num_bits))); |
There was a problem hiding this comment.
This is generating cases where end_bit < begin_bit, likely due to Catch2 generator lifetime issues -- it doesn't seem to be updating the generator expressions as expected, even with GENERATE_COPY. I don't think Catch2 expects the values of the captured variables to be changed dynamically like this.
I'll leave this as is for now.
There was a problem hiding this comment.
@allisonvacanti I was not able to reproduce this:
#define CATCH_CONFIG_MAIN
#include <catch2/catch.hpp>
TEST_CASE("Test", "[test]") {
const int num_bits = 64;
const int dummy = GENERATE_COPY(range(0, num_bits));
const int begin_bit = GENERATE_COPY(take(300, random(0, num_bits)));
const int end_bit = GENERATE_COPY(take(300, random(begin_bit, num_bits)));
if (end_bit < begin_bit) {
INFO("begin_bit = " << begin_bit);
INFO("end_bit = " << end_bit);
FAIL("end_bit < begin_bit");
}
}Do you have a reproducer?
There was a problem hiding this comment.
IIRC I was using something like this:
const int begin_bit = GENERATE_COPY(take(2, random(0, num_bits)));
const int end_bit = GENERATE_COPY(begin_bit, take(2, random(begin_bit, num_bits)));
to make sure that we'd always cover the begin_bit == end_bit edgecase.
alliepiper
force-pushed
the
catch2-device-radix-sort
branch
from
8c9103d
to
3aa5873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #86.
This adds basic testing. A future PR will include tests for segmented sort and large inputs (>2^32 items), at which point the old radix sort tests can be removed.