Fix availability of is_constant_evaluated on old MSVC
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ptheywood found that there is an unfortunate incompatability of MSVC2019 which does support `__builtin_is_constant_evaluated` from 19.24 onwards and old nvcc below 11.3 which does not. Fix this by hardening the condition we use to detect availability Fixes NVIDIA#1179
miscco
added
libcu++
jrhemstad
approved these changes
Dec 8, 2023
|
GitHub Actions is not permitted to create or approve pull requests. |
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Dec 8, 2023
@ptheywood found that there is an unfortunate incompatability of MSVC2019 which does support `__builtin_is_constant_evaluated` from 19.24 onwards and old nvcc below 11.3 which does not. Fix this by hardening the condition we use to detect availability Fixes NVIDIA#1179
jrhemstad
pushed a commit
that referenced
this pull request
Dec 13, 2023
@ptheywood found that there is an unfortunate incompatability of MSVC2019 which does support `__builtin_is_constant_evaluated` from 19.24 onwards and old nvcc below 11.3 which does not. Fix this by hardening the condition we use to detect availability Fixes #1179
miscco
added
backport done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ptheywood found that there is an unfortunate incompatability of MSVC2019 which does support
__builtin_is_constant_evaluatedfrom 19.24 onwards and old nvcc below 11.3 which does not.Fix this by hardening the condition we use to detect availability
Fixes #1179