Clarify Thrust/CUB ABI guarantees #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
requested changes
Jan 11, 2024
README.md
Outdated
| - The ABI of `cub::` symbols includes the CUDA architectures used for compilation. Therefore, a single `cub::` symbol may have a different ABI if compiled with different architectures. | ||
| - The ABI of `thrust::` and `cub::` symbols includes the CUDA architectures used for compilation. Therefore, a single `cub::` symbol may have a different ABI if: | ||
| - compiled with different architectures | ||
| - compiled with nvcc vs host compiler only |
There was a problem hiding this comment.
This should be something like compiled from a CUDA source file compared to a C++ file. By a literal reading of this line nvcc -x c++ would infer same ABI as nvcc -x cu which isn't correct. It also fails to distinguish how to reason when clang++ is both the C++ and CUDA compiler ( no nvcc at all ).
jrhemstad
commented
Jan 11, 2024
robertmaynard
approved these changes
Jan 11, 2024
gevtushenko
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
thrust::to the docs about the archs included as an inline namespace, and further added additional detail about ABI incompatibility between host/device TUs.