Ports cub::DeviceMergeSort tests to Catch2
#1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Jan 26, 2024
elstehle
force-pushed
the
enh/catch2-device-merge-sort
branch
from
4a74015
to
1e07f80
Compare
gevtushenko
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1211
This PR migrates tests for
cub::DeviceMergeSortto Catch2.For our
DeviceMergeSortinterfaces that do not explicitly perform a stable sort, I tried to not imply that our current implementation is stable. So, similar to our original tests, I'm generating unique sort keys where there is no tie between any two input items. This ensures there's just a single one correct order for the result.For the
DeviceMergeSortinterfaces that are stable, I try to cause multiple ties on the sort keys to test that the sort is indeed stable and that we maintain the relative input order between tied sort keys.Checklist