Improve compiler detection defines #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaraslaut
changed the title
miscco
requested changes
Jan 25, 2024
Yaraslaut
force-pushed
the
improvement/compiler_detection_defines
branch
from
3d6c6c4
to
9646d32
Compare
Yaraslaut
force-pushed
the
improvement/compiler_detection_defines
branch
from
9646d32
to
b56c2af
Compare
|
@miscco i updated PR |
miscco
requested changes
Jan 26, 2024
libcudacxx/include/cuda/std/detail/libcxx/include/__cccl_config
Outdated
Show resolved
Hide resolved
Yaraslaut
force-pushed
the
improvement/compiler_detection_defines
branch
from
c17a2f5
to
df32822
Compare
miscco
reviewed
Feb 1, 2024
There was a problem hiding this comment.
This looks good. As this touches a lot of code I would like a second review from @allisonvacanti or @gevtushenko
|
/ok to test |
|
@miscco can you please rerun tests? |
|
/ok to test |
|
/ok to test |
miscco
approved these changes
Feb 8, 2024
miscco
added
feature request
|
/ok to test |
dkolsen-pgi
added a commit
to dkolsen-pgi/cccl
that referenced
this pull request
Feb 21, 2024
PR NVIDIA#1320 broke compilation with NVC++ when `<thrust/random.h>` was the first header to be included. This code that was there previously ``` defined(_CCCL_COMPILER_CLANG) || \ defined(_CCCL_COMPILER_ICC) ``` does not include `<stdint.h>` when NVC++ is the compiler, but the file uses types defined in `<stdint.h>`, such as: ``` typedef ::int8_t int8_t; typedef ::int16_t int16_t; ``` Fix this problem by using the same `#if` condition for including `<stdint.h>` as for using the ``::intN_t` types.
2 tasks
miscco
pushed a commit
that referenced
this pull request
Feb 21, 2024
PR #1320 broke compilation with NVC++ when `<thrust/random.h>` was the first header to be included. This code that was there previously ``` defined(_CCCL_COMPILER_CLANG) || \ defined(_CCCL_COMPILER_ICC) ``` does not include `<stdint.h>` when NVC++ is the compiler, but the file uses types defined in `<stdint.h>`, such as: ``` typedef ::int8_t int8_t; typedef ::int16_t int16_t; ``` Fix this problem by using the same `#if` condition for including `<stdint.h>` as for using the ``::intN_t` types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #572
__cccl__confgsuch as_CCCL_COMPILER_[CLANG|GCC|MSVC ...Checklist