鈾伙笍馃摑 Update mode example to use thrust::unique_count
#1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
miscco
approved these changes
Feb 8, 2024
elstehle
requested changes
Feb 8, 2024
elstehle
approved these changes
Feb 9, 2024
Will do. Can you add me as the assignee so I get a notification? Only saw this because I randomly checked the status of the PR. Update: Just saw that @miscco did. Thx 馃檹 |
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When this example was created, thrust::unique_count did not exist. It was added in 2022 (2 years ago) in this PR: NVIDIA/thrust#1612. It shouldn't definitely be used now.
I noticed this while @brycelelbach and I were chatting about this algorithm while recording an episode of ADSP 馃槂