CMake support absolute CMAKE_INSTALL_LIBDIR values #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
reviewed
Feb 16, 2024
There was a problem hiding this comment.
I won't pretend to understand any of this and wholly defer to @allisonvacanti. My only question is if there's a way to add a test for this to make sure we don't break it again in the future.
alliepiper
reviewed
Feb 16, 2024
alliepiper
requested changes
Feb 16, 2024
robertmaynard
force-pushed
the
support_abs_libdir
branch
from
ea8bf85
to
9c553d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows us to support absolute
CMAKE_INSTALL_LIBDIRpaths when they are rooted inCMAKE_INSTALL_PREFIX.Fixes #1390
Checklist