Disallow float offset type in cub::segmented_reducde #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonidelis
commented
Feb 23, 2024
miscco
requested changes
Feb 24, 2024
gevtushenko
reviewed
Feb 26, 2024
gevtushenko
reviewed
Feb 29, 2024
gonidelis
force-pushed
the
segmented_reduce_error_reporting
branch
6 times, most recently
from
35bab94
to
b171103
Compare
gevtushenko
reviewed
Mar 5, 2024
gonidelis
force-pushed
the
segmented_reduce_error_reporting
branch
from
81c9ec5
to
f42a631
Compare
gevtushenko
reviewed
Mar 6, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
gevtushenko
approved these changes
Mar 8, 2024
|
@miscco merge? |
gonidelis
force-pushed
the
segmented_reduce_error_reporting
branch
from
16aa410
to
4cac551
Compare
gonidelis
force-pushed
the
segmented_reduce_error_reporting
branch
from
4cac551
to
868d50c
Compare
miscco
approved these changes
Mar 12, 2024
miscco
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1221 for introducing tag_dispatching intermediate layer in cub::SegmentedReduce that improves error reporting and enforces that the offset type be integral.
Checklist