Add cuda::ptx::cp_reduce_async_bulk
#1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Feb 28, 2024
miscco
reviewed
Feb 28, 2024
1. Add the ifdef 2. Add min, max support for f16 and bf16 (I overlooked this initially)
ahendriksen
force-pushed
the
add-ptx-cp-reduce-async-bulk
branch
from
44aa1af
to
312c5b6
Compare
miscco
reviewed
Feb 28, 2024
| } | ||
| #endif // __cccl_ptx_isa >= 800 | ||
|
|
||
| #ifdef _LIBCUDACXX_HAS_NVF16 |
There was a problem hiding this comment.
Note, the PR that brings this in has not been merged, so that will currently always be off until we merge #1140
There was a problem hiding this comment.
Okay.. This issue probably caused the tests to fail, so I have guarded the tests on this macro as well.
I am okay with the __half and bfloat16 variants not being available immediately. I have tested the generated PTX offline, so I know it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1444
Checklist