Ensure that we can test libcu++ against architectures < 70 #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
nvbug
In our header test suite we compile headers that require a certain architecture only against those architectures that actually satisfy the requirement. We missed the case when no architecture satisfy the constraints and we should not test that header at all. Fixes nvbug4541374
miscco
force-pushed
the
fix_header_test_architectures
branch
from
3e36159
to
f25dd8e
Compare
wmaxey
approved these changes
Mar 4, 2024
|
GitHub Actions is not permitted to create or approve pull requests. |
miscco
removed
the
backport branch/2.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our header test suite we compile headers that require a certain architecture only against those architectures that actually satisfy the requirement.
We missed the case when no architecture satisfy the constraints and we should not test that header at all.
Fixes nvbug4541374
Description
closes
Checklist