Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CUB's catch2 test binaries by default for CI. #1482

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

alliepiper
Copy link
Collaborator

No description provided.

@alliepiper alliepiper requested review from a team as code owners March 4, 2024 21:18
@miscco
Copy link
Collaborator

miscco commented Mar 5, 2024

That error is really strange:

  FAILED: cub/test/CMakeFiles/cub.cpp11.test.device_segmented_reduce_iterators_64bit.lid_0.dir/catch2_test_device_segmented_reduce_iterators_64bit.cu.o 
  /usr/bin/sccache /usr/local/cuda/bin/nvcc -forward-unknown-to-host-compiler -ccbin=/usr/bin/g++ -DCUB_CONFIG_MAIN -DCUB_IGNORE_DEPRECATED_CPP_DIALECT -DTEST_LAUNCH=0 -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -DVAR_IDX=0 -D_CCCL_NO_SYSTEM_HEADER -I/home/coder/cccl/cub/test -I/home/coder/cccl/cub/cub/cmake/../.. -I/home/coder/cccl/libcudacxx/lib/cmake/libcudacxx/../../../include -I/home/coder/cccl/thrust/thrust/cmake/../.. -isystem /usr/local/cuda/targets/x86_64-linux/include -isystem /home/coder/cccl/build/cub-cpp11/Metal/include -isystem /home/coder/cccl/build/cub-cpp11/_deps/catch2-src/single_include -O3 -DNDEBUG -std=c++11 "--generate-code=arch=compute_60,code=[compute_60,sm_60]" "--generate-code=arch=compute_70,code=[compute_70,sm_70]" "--generate-code=arch=compute_80,code=[compute_80,sm_80]" -Xcompiler=-Werror -Xcompiler=-Wall -Xcompiler=-Wextra -Xcompiler=-Winit-self -Xcompiler=-Woverloaded-virtual -Xcompiler=-Wcast-qual -Xcompiler=-Wpointer-arith -Xcompiler=-Wvla -Xcompiler=-Wno-gnu-line-marker -Xcompiler=-Wno-gnu-zero-variadic-macro-arguments -Xcompiler=-Wno-unused-function -Wreorder -Xcudafe=--display_error_number -Xcudafe=--promote_warnings -Wno-deprecated-gpu-targets -MD -MT cub/test/CMakeFiles/cub.cpp11.test.device_segmented_reduce_iterators_64bit.lid_0.dir/catch2_test_device_segmented_reduce_iterators_64bit.cu.o -MF cub/test/CMakeFiles/cub.cpp11.test.device_segmented_reduce_iterators_64bit.lid_0.dir/catch2_test_device_segmented_reduce_iterators_64bit.cu.o.d -x cu -c /home/coder/cccl/cub/test/catch2_test_device_segmented_reduce_iterators_64bit.cu -o cub/test/CMakeFiles/cub.cpp11.test.device_segmented_reduce_iterators_64bit.lid_0.dir/catch2_test_device_segmented_reduce_iterators_64bit.cu.o
  /home/coder/cccl/cub/test/catch2_main.cuh(52): error #135: namespace "Catch" has no member "Session"
  
  /home/coder/cccl/cub/test/catch2_main.cuh(57): error #135: namespace "Catch" has no member "clara"
  
  /home/coder/cccl/cub/test/catch2_main.cuh(59): error #20: identifier "Opt" is undefined
  
  3 errors detected in the compilation of "/home/coder/cccl/cub/test/catch2_test_device_segmented_reduce_iterators_64bit.cu".

@alliepiper
Copy link
Collaborator Author

@miscco I've seen that when the catch2 header is included in a test case (usually when VSCode automatically inserts it -_-). I think we found a WAR for these issues, I'll try to get that in ASAP.

@alliepiper alliepiper requested a review from a team as a code owner March 5, 2024 16:25
@alliepiper
Copy link
Collaborator Author

This is ready for review and should unblock folks who are stuck on CI timeouts.

@alliepiper alliepiper merged commit b22d759 into NVIDIA:main Mar 6, 2024
584 checks passed
@alliepiper alliepiper deleted the cub_separate_tests branch March 6, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants