Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Provide instructions to change SCP port #42

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jan 8, 2021

Description

  • Extracted DICOM SCP port & WWW port to values.yaml
  • Update setup.md to provide instructions on where to modify DICOM SCP port.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • NGC publishing metadata updated.
  • I have updated the changelog

@mocsharp mocsharp self-assigned this Jan 8, 2021
@mocsharp mocsharp changed the base branch from main to release/0.8.1 January 8, 2021 23:30
@mocsharp mocsharp changed the title Provide instructions on how to change SCP port Provide instructions to change SCP port Jan 8, 2021
Copy link
Contributor

@igobypenn igobypenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update documentations to give helm install --set configurations overrides as a sample.
Since this uses host pots, there should be a note about that and maybe some simple debugging techniques for quick identification for users.

@mocsharp mocsharp merged commit 40559f5 into NVIDIA:release/0.8.1 Jan 14, 2021
@mocsharp mocsharp deleted the update-helm-docs branch January 14, 2021 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants