Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Add static_multiset::count_outer #488

Closed
sleeepyjack opened this issue May 16, 2024 · 2 comments
Closed

[FEATURE]: Add static_multiset::count_outer #488

sleeepyjack opened this issue May 16, 2024 · 2 comments
Assignees
@PointKernel
Labels
helps: rapids Helps or needed by RAPIDS P0: Must have Critical feature or bug fix topic: static_multiset Issue related to the static_multiset type: feature request New feature request
Milestone
static_multiset

Comments

@sleeepyjack
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

static_multiset requires an equivalent function to static_multimap::count_outer.

Describe the solution you'd like

After #462 is finished, add a new API count_outer and also add a template parameter to the kernel to switch between count and count_outer behavior.

Describe alternatives you've considered

Still an open discussion if this is the best approach to tackle this problem but we couldn't come up with a better solution so far.

Additional context

No response
@sleeepyjack sleeepyjack added type: feature request New feature request P0: Must have Critical feature or bug fix topic: static_multiset Issue related to the static_multiset labels May 16, 2024
@sleeepyjack sleeepyjack added this to the static_multiset milestone May 16, 2024
@sleeepyjack sleeepyjack added the helps: rapids Helps or needed by RAPIDS label May 16, 2024
@PointKernel
Copy link
Member

PointKernel commented May 21, 2024 •
edited
Loading

Similar to retrieve_outer, this API is probably cudf-specific and should take probe hash and probe key equal as arguments.

@PointKernel PointKernel self-assigned this May 21, 2024
@PointKernel PointKernel mentioned this issue May 23, 2024
Merged
PointKernel added a commit that referenced this issue May 28, 2024
@PointKernel @sleeepyjack
Add multiset custom count APIs (#490)
cd7b588 
Closes #462, closes #488

This PR adds custom `count` APIs desired by libcudf hash join.

---------

Co-authored-by: Daniel Jünger <2955913+sleeepyjack@users.noreply.github.com>
@PointKernel
Copy link
Member

Closed by #490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PointKernel PointKernel

Labels
helps: rapids Helps or needed by RAPIDS P0: Must have Critical feature or bug fix topic: static_multiset Issue related to the static_multiset type: feature request New feature request
Projects
None yet
Milestone
static_multiset
Development

No branches or pull requests
2 participants
@sleeepyjack @PointKernel