Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Only use nv_exec_check_disable on nvcc. #411

Merged

Conversation

alliepiper
Copy link
Collaborator

This patch adds the same guards around the pragma that we use in Thrust.

Bug 3453249

@alliepiper alliepiper added type: bug: functional Does not work as intended. nvbug Has an associated internal NVIDIA NVBug. P0: must have Absolutely necessary. Critical issue, major blocker, etc. labels Dec 3, 2021
@alliepiper alliepiper added this to the 1.16.0 milestone Dec 3, 2021
@alliepiper alliepiper added this to Inbox in PR Tracking via automation Dec 3, 2021
@alliepiper alliepiper moved this from Inbox to Need Review in PR Tracking Dec 3, 2021
alliepiper added a commit to alliepiper/thrust that referenced this pull request Dec 3, 2021
@alliepiper
Copy link
Collaborator Author

gpuCI: NVIDIA/thrust#1574
DVS CL: 30734665

@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Dec 3, 2021
cub/detail/exec_check_disable.cuh Show resolved Hide resolved
cub/detail/exec_check_disable.cuh Outdated Show resolved Hide resolved
cub/detail/exec_check_disable.cuh Show resolved Hide resolved
cub/detail/exec_check_disable.cuh Outdated Show resolved Hide resolved
cub/detail/exec_check_disable.cuh Show resolved Hide resolved
@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Dec 13, 2021
This patch adds the same guards around the pragma that we use in Thrust.

Bug 3453249
@alliepiper alliepiper force-pushed the nvbug.3453249/guard_nv_exec_check_disable branch from 4b6070b to 7d608bf Compare December 13, 2021 20:17
@alliepiper alliepiper merged commit ec07c16 into NVIDIA:main Dec 13, 2021
PR Tracking automation moved this from Need Review to Done Dec 13, 2021
@alliepiper alliepiper deleted the nvbug.3453249/guard_nv_exec_check_disable branch December 13, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
nvbug Has an associated internal NVIDIA NVBug. P0: must have Absolutely necessary. Critical issue, major blocker, etc. testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). type: bug: functional Does not work as intended.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants