This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix temp storage allocation in adjacent difference copy #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
added
the
P0: must have
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jun 9, 2022
This was referenced Jun 9, 2022
gevtushenko
added
testing: gpuCI passed
gevtushenko
force-pushed
the
fix-main/github/adj_diff_copy
branch
from
4203e1d
to
282a996
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jun 22, 2022
gevtushenko
force-pushed
the
fix-main/github/adj_diff_copy
branch
from
282a996
to
0ecb2c9
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jun 22, 2022
alliepiper
approved these changes
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues (first, second). The copy version of the API didn't use to skip computation at the stage of temporary storage evaluation.