This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 446
Support user-defined types in radix sort and introduce initial sphinx docs #671
Merged
gevtushenko
merged 7 commits into
NVIDIA:main
from
gevtushenko:enh-main/github/custom_radix
May 21, 2023
Merged
Support user-defined types in radix sort and introduce initial sphinx docs #671
gevtushenko
merged 7 commits into
NVIDIA:main
from
gevtushenko:enh-main/github/custom_radix
May 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Apr 6, 2023
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Apr 7, 2023
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Apr 7, 2023
jrhemstad
reviewed
Apr 21, 2023
This was referenced Apr 24, 2023
jrhemstad
approved these changes
May 4, 2023
miscco
reviewed
May 11, 2023
gevtushenko
commented
May 15, 2023
elstehle
reviewed
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really solid work! Like how we can keep most of the implementation details unchanged.
Partial review; review of BlockRadixSort
and tests remaining. Also want to push radix_rank_sort_operations
through its paces a bit.
ericniebler
reviewed
May 18, 2023
elstehle
reviewed
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few, mostly minor, comments remaining 🙂
elstehle
approved these changes
May 19, 2023
803e61a
to
d428ad3
Compare
e1ea3c9
to
d1dcb77
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
May 20, 2023
This was referenced May 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for user-defined types in the block / device radix sort (addresses #52):
There's no difference in performance between sorting a key that's a pair of
int32
and sorting a singleint64
key. The PR also doesn't affect SASS for fundamental types.Documentation for the new API is written using sphinx, whose initial support is also introduced by this PR. Doxygen is temporarily broken, and a follow-up PR will provide the complete transition to sphinx. To build sphinx docs: