Fixing issue with sample_async failing on machines with multiple GPUs #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In library mode, we need to run a tracing pass before actual execution. With multi-qpu, we set_exec_ctx on specific qpu id but didn't reset the context on that particular qpu id (fall back to reset QPU 0 context all the time).
bettinaheim
changed the title
sample.h affecting sample_async in library mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In library mode, we need to run a tracing pass before actual execution.
With multi-qpu, we
set_exec_ctxon specific QPU id but didn't reset the context on that particular qpu id (fall back to reset QPU 0 context all the time).Resolves #1374