Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix synthesis of vectors with small integers. #1395

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix synthesis of vectors with small integers. #1395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5f0ee
Fix #1348 - synthesis of vectors with small integers.
schweitzpgi Mar 14, 2024
6fa0fd6
Fix build issue.
schweitzpgi Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 47 additions & 4 deletions lib/Optimizer/Transforms/QuakeSynthesizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,40 @@ LogicalResult synthesizeVectorArgument(OpBuilder &builder,
return success();
}

template <typename A>
std::vector<std::int32_t> asI32(const std::vector<A> &v) {
std::vector<std::int32_t> result(v.size());
for (auto iter : llvm::enumerate(v))
result[iter.index()] = static_cast<std::int32_t>(iter.value());
return result;
}

// TODO: consider using DenseArrayAttr here instead. NB: such a change may alter
// the output of the constant array op.
static LogicalResult synthesizeVectorArgument(OpBuilder &builder,
BlockArgument argument,
std::vector<bool> &vec) {
auto arrayAttr = builder.getI32ArrayAttr(asI32(vec));
return synthesizeVectorArgument<IntegerType>(
builder, argument, vec, arrayAttr, makeIntegerElement<bool>);
}

static LogicalResult synthesizeVectorArgument(OpBuilder &builder,
BlockArgument argument,
std::vector<std::int8_t> &vec) {
auto arrayAttr = builder.getI32ArrayAttr(asI32(vec));
return synthesizeVectorArgument<IntegerType>(
builder, argument, vec, arrayAttr, makeIntegerElement<std::int8_t>);
}

static LogicalResult synthesizeVectorArgument(OpBuilder &builder,
BlockArgument argument,
std::vector<std::int16_t> &vec) {
auto arrayAttr = builder.getI32ArrayAttr(asI32(vec));
return synthesizeVectorArgument<IntegerType>(
builder, argument, vec, arrayAttr, makeIntegerElement<std::int16_t>);
}

static LogicalResult synthesizeVectorArgument(OpBuilder &builder,
BlockArgument argument,
std::vector<std::int32_t> &vec) {
Expand Down Expand Up @@ -449,12 +483,21 @@ class QuakeSynthesizer
};
if (auto ty = dyn_cast<IntegerType>(eleTy)) {
switch (ty.getIntOrFloatBitWidth()) {
case 32: {
case 1:
doVector(false);
break;
case 8:
doVector(std::int8_t{});
break;
case 16:
doVector(std::int16_t{});
break;
case 32:
doVector(std::int32_t{});
} break;
case 64: {
break;
case 64:
doVector(std::int64_t{});
} break;
break;
default:
bufferAppendix += vecLength * (ty.getIntOrFloatBitWidth() / 8);
funcOp.emitOpError("synthesis failed for vector<integral-type>.");
Expand Down
Loading