Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect error for synthesis of callables #1398

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Mar 14, 2024

Change the catch-all for structs to NOT raise an error for callables and empty structs (which are more than likely callable classes).

Fix #1392

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Refactor the code that was to catch struct value passing (which is
not yet implemented) from arguments that are callables.

Fix NVIDIA#1392
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
@schweitzpgi schweitzpgi merged commit 1ced08c into NVIDIA:main Mar 14, 2024
133 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@bettinaheim bettinaheim changed the title Fix #1392: "synthesis" of callables Fixing incorrect error for synthesis of callables Apr 17, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuakeSynthesizer outputs error diagnostic logs when seeing callable arguments
3 participants