Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI testing for Python 3.8 #1403

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Conversation

bmhowe23
Copy link
Collaborator

I suspect we'll see a few minor test failures. Triggering the CI to find out which ones.

Then we need to change the branch protection rules to look for test results from 3.8 vice 3.9.

Resolves #1313.

github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Pradnya had made that change, but maybe it got lost with merge updates.

@bmhowe23
Copy link
Collaborator Author

I thought Pradnya had made that change, but maybe it got lost with merge updates.

Yes, she made that change in the experimental/python branch, but we could not merge it to main at the time due to branch protection rules still expecting test results from 3.9. Speaking of which, when you're ready to merge this to main, would you please update the branch protection rules to expect the checks for Python 3.8 instead of Python 3.9?

@bmhowe23 bmhowe23 marked this pull request as ready for review March 14, 2024 21:00
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
@schweitzpgi
Copy link
Collaborator

I thought Pradnya had made that change, but maybe it got lost with merge updates.

Yes, she made that change in the experimental/python branch, but we could not merge it to main at the time due to branch protection rules still expecting test results from 3.9. Speaking of which, when you're ready to merge this to main, would you please update the branch protection rules to expect the checks for Python 3.8 instead of Python 3.9?

I have a build change that piles on her change that will help.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@bmhowe23 bmhowe23 enabled auto-merge (squash) March 26, 2024 19:30
@bmhowe23 bmhowe23 merged commit c85412e into NVIDIA:main Mar 26, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@bmhowe23 bmhowe23 deleted the pr-fix-i1313 branch March 26, 2024 20:12
@bettinaheim bettinaheim added the maintenance Work items to update and improve the code base label Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Work items to update and improve the code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should probably change CI and branch protection rules to do testing on Python 3.8
3 participants