-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI testing for Python 3.8 #1403
Conversation
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Pradnya had made that change, but maybe it got lost with merge updates.
Yes, she made that change in the experimental/python branch, but we could not merge it to main at the time due to branch protection rules still expecting test results from 3.9. Speaking of which, when you're ready to merge this to main, would you please update the branch protection rules to expect the checks for Python 3.8 instead of Python 3.9? |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
I have a build change that piles on her change that will help. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
I suspect we'll see a few minor test failures. Triggering the CI to find out which ones.
Then we need to change the branch protection rules to look for test results from 3.8 vice 3.9.
Resolves #1313.