Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when passing np.ndarray to Python kernels #1406

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Fix issue when passing np.ndarray to Python kernels #1406

merged 7 commits into from
Mar 21, 2024

Conversation

amccaskey
Copy link
Collaborator

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey amccaskey mentioned this pull request Mar 15, 2024
Merged
@amccaskey
Copy link
Collaborator Author

amccaskey commented Mar 15, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@cuda-quantum-bot
Docs preview for PR #1406.
b7c58c4
@amccaskey
Fix value error bug with validating mlirTypeFromPyType for np.array
22ecdc4 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
add the test
b0250cf 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
fix ci failure
8ecf677 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Mar 16, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) March 16, 2024 14:04
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 16, 2024
@cuda-quantum-bot
Docs preview for PR #1406.
a0a9b06
bmhowe23
bmhowe23 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amccaskey amccaskey disabled auto-merge March 18, 2024 19:48
@amccaskey
Copy link
Collaborator Author

amccaskey commented Mar 18, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Mar 20, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@cuda-quantum-bot
Docs preview for PR #1406.
23120e2
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Mar 20, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 enabled auto-merge (squash) March 20, 2024 22:46
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@cuda-quantum-bot
Docs preview for PR #1406.
a0c0d6c
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Mar 21, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 merged commit 81db600 into NVIDIA:main Mar 21, 2024
133 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
@bettinaheim bettinaheim changed the title Fix value error bug with validating mlirTypeFromPyType for np.ndarray Fix issue when passing np.ndarray to Python kernels Apr 17, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amccaskey @bmhowe23 @bettinaheim