Adds commit: [refactoring] Remove code duplication for nvcf client classes (#1334) #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1334) Define base class `BaseNvcfRuntimeClient` from which `NvcfRuntimeClient` (C++) and `PyNvcfRuntimeClient` (Python) inherit so as to remove the duplicate code across files / classes.
cuda-quantum-bot
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
cuda-quantum-bot
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
cuda-quantum-bot
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
khalatepradnya
approved these changes
Mar 18, 2024
bmhowe23
approved these changes
Mar 18, 2024
anthony-santana
merged commit 2edf4c9
into
NVIDIA:features/docs_refactor
76 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following missing commit:
Define base class
BaseNvcfRuntimeClientfrom whichNvcfRuntimeClient(C++) andPyNvcfRuntimeClient(Python) inherit so as to remove the duplicate code across files / classes.