Fixed an oversight in PR#1002 #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an oversight in constructing the return `observe_result` only containing the overall expectation value. Our code requires that it must contain a sample_result with a single ExecutionResult on the register named with the spin_op string. Hence, fixing the oversight and add a test for this.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an oversight in constructing the return
observe_resultonly containing the overall expectation value.In particular, this diff in PR#1002:
https://github.com/NVIDIA/cuda-quantum/pull/1002/files#diff-8e5c3472b761fa649ea9d6448655c52b694663a809e4ff569c26e1daee6813cb
we didn't construct the equivalent
sample_resultwith a singleExecutionResulton the register namedH.to_string(false)when the backend only return a single expectation value.Hence, this fixes that oversight and adds a test case.
Note: the implementation in
custatevecalready had the full set ofsample_result's.