Fix QPUD Library Mode Installer Build #1435

1tnguyen · 2024-03-22T21:15:20Z

Description

Root cause: missing symbols (e.g., those errors reported in #1281) is due to static linking to libstdc++ (only installer build uses this configuration). Specifically, the incoming LLVM IR may reference symbols that qpud and its dependencies never saw.

Note: in #1281, when we activated the MPI plugin, everything worked because the MPI plugin .so is linked (dynamic) to libstdc++.so. That plugin is then loaded (dlopen) at runtime, hence all symbols are available via dynamic lookup.

Fixes:

Modify CMake config of the qpud tool to include the full libstdc++ archive if static linking to libstdc++ is required.
Also, add the missing export_executable_symbols_for_plugins. Remove the unnecessary setAutoClaimResponsibilityForObjectSymbols (was probably a workaround for the missing export_executable_symbols_for_plugins).
Unify the C++-20 and C++-17 paths in some of the observe/sample APIs using the existing make_copyable_function helper.
Re-add the targettests lit test suite to installer CI check. Remove the bypass clause (REQUIRES: c++20) in remote-mqpu tests.

Resolved: #1111 and #1281

github-actions · 2024-03-23T03:27:29Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

copy-pr-bot · 2024-03-24T22:48:26Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

1tnguyen · 2024-03-24T23:25:59Z

Command Bot: Processing...

github-actions · 2024-03-25T02:32:02Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2024-03-25T03:12:13Z

Command Bot: Processing...

github-actions · 2024-03-25T06:07:25Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2024-03-25T06:37:39Z

Command Bot: Processing...

github-actions · 2024-03-25T09:34:01Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

This reverts commit 7e83939.

1tnguyen · 2024-03-25T23:19:43Z

Command Bot: Processing...

github-actions · 2024-03-26T02:13:09Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2024-03-27T02:03:25Z

Command Bot: Processing...

github-actions · 2024-03-27T05:11:12Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2024-03-27T05:19:55Z

Command Bot: Processing...

github-actions · 2024-03-27T06:07:17Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2024-04-04T01:38:50Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions · 2024-04-04T02:32:02Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2024-04-12T06:30:41Z

Command Bot: Processing...

github-actions · 2024-04-12T08:54:31Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

In this PR, we've re-enabled C++17 tests for the installer build CI, hence we need to adjust those tests that use C++20 syntax.

1tnguyen · 2024-04-12T19:38:57Z

Command Bot: Processing...

github-actions · 2024-04-12T22:00:19Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen · 2024-04-12T22:57:00Z

Command Bot: Processing...

github-actions · 2024-04-13T01:33:52Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

targettests/Remote-Sim/free_func.cpp

targettests/Remote-Sim/observe.cpp

targettests/Remote-Sim/observe_async.cpp

Move C++17 tests into separate test files.

1tnguyen · 2024-04-16T01:55:46Z

Command Bot: Processing...

1tnguyen · 2024-04-17T04:00:43Z

Command Bot: Processing...

github-actions · 2024-04-17T04:53:35Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23 · 2024-04-17T12:32:31Z

runtime/common/JIT.cpp

@@ -109,10 +111,6 @@ void invokeWrappedKernel(std::string_view irString,
          return std::make_unique<llvm::SectionMemoryManager>();
        });
    llvm::Triple targetTriple(llvm::Twine(llvmModule->getTargetTriple()));
-    // IMPORTANT: need to setAutoClaimResponsibilityForObjectSymbols to true to


The removal of these lines probably means we need to edit the comments in runtime/common/JIT.h, too.

Fixed #1533.

1tnguyen and others added 2 commits March 23, 2024 08:11

Experimenting fixes for lib mode for qpud in the installer

4a85c98

Merge branch 'main' into tnguyen/installer-qpud-lib-mode

81eafb1

github-actions bot pushed a commit that referenced this pull request Mar 23, 2024

Docs preview for PR #1435.

4cfa40f

Add %cpp_std to run commands

79fe9b0

github-actions bot pushed a commit that referenced this pull request Mar 25, 2024

Docs preview for PR #1435.

b6802ac

Use make_copyable_function util

91be627

github-actions bot pushed a commit that referenced this pull request Mar 25, 2024

Docs preview for PR #1435.

0106a80

Debug the missing symbol

7e83939

github-actions bot pushed a commit that referenced this pull request Mar 25, 2024

Docs preview for PR #1435.

4ea566e

1tnguyen added 2 commits March 26, 2024 10:16

Revert "Debug the missing symbol"

be18e22

This reverts commit 7e83939.

Try something

d1707af

github-actions bot pushed a commit that referenced this pull request Mar 26, 2024

Docs preview for PR #1435.

b7695dc

Trying a fix

63d6fdb

github-actions bot pushed a commit that referenced this pull request Mar 27, 2024

Docs preview for PR #1435.

2a9fd45

Merge branch 'main' into tnguyen/installer-qpud-lib-mode

afb5779

github-actions bot pushed a commit that referenced this pull request Mar 27, 2024

Docs preview for PR #1435.

ac9210c

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024

Docs preview for PR #1435.

ddcdb15

github-actions bot pushed a commit that referenced this pull request Apr 4, 2024

Docs preview for PR #1435.

280556b

Merge branch 'main' into tnguyen/installer-qpud-lib-mode

f249a56

github-actions bot pushed a commit that referenced this pull request Apr 12, 2024

Docs preview for PR #1435.

d4cddb9

Fixes after merge

19beb05

In this PR, we've re-enabled C++17 tests for the installer build CI, hence we need to adjust those tests that use C++20 syntax.

github-actions bot pushed a commit that referenced this pull request Apr 12, 2024

Docs preview for PR #1435.

9a1dfbd

Fixed a typo: REQURIES -> REQUIRES

ef84840

github-actions bot pushed a commit that referenced this pull request Apr 13, 2024

Docs preview for PR #1435.

b178e43

schweitzpgi reviewed Apr 15, 2024

View reviewed changes

targettests/Remote-Sim/free_func.cpp Outdated Show resolved Hide resolved

targettests/Remote-Sim/free_func.cpp Outdated Show resolved Hide resolved

targettests/Remote-Sim/observe.cpp Outdated Show resolved Hide resolved

targettests/Remote-Sim/observe_async.cpp Outdated Show resolved Hide resolved

1tnguyen and others added 2 commits April 16, 2024 10:23

Merge branch 'main' into tnguyen/installer-qpud-lib-mode

2c76555

Address code review

4ad7ecd

Move C++17 tests into separate test files.

schweitzpgi approved these changes Apr 16, 2024

View reviewed changes

Merge branch 'main' into tnguyen/installer-qpud-lib-mode

574dcef

github-actions bot pushed a commit that referenced this pull request Apr 17, 2024

Docs preview for PR #1435.

5ccd3eb

1tnguyen merged commit 9df2fe6 into NVIDIA:main Apr 17, 2024
125 checks passed

github-actions bot locked and limited conversation to collaborators Apr 17, 2024

bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024

bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 17, 2024

bmhowe23 reviewed Apr 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix QPUD Library Mode Installer Build #1435

Fix QPUD Library Mode Installer Build #1435

1tnguyen commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 23, 2024

copy-pr-bot bot commented Mar 24, 2024

1tnguyen commented Mar 24, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 25, 2024

1tnguyen commented Mar 25, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 25, 2024

1tnguyen commented Mar 25, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 25, 2024

1tnguyen commented Mar 25, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 26, 2024

1tnguyen commented Mar 27, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 27, 2024

1tnguyen commented Mar 27, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 27, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

1tnguyen commented Apr 12, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Apr 12, 2024

1tnguyen commented Apr 12, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Apr 12, 2024

1tnguyen commented Apr 12, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Apr 13, 2024

1tnguyen commented Apr 16, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Apr 17, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Apr 17, 2024

bmhowe23 Apr 17, 2024

1tnguyen Apr 17, 2024

Fix QPUD Library Mode Installer Build #1435

Fix QPUD Library Mode Installer Build #1435

Conversation

1tnguyen commented Mar 22, 2024 • edited Loading

Description

github-actions bot commented Mar 23, 2024

copy-pr-bot bot commented Mar 24, 2024

1tnguyen commented Mar 24, 2024 • edited by github-actions bot Loading

github-actions bot commented Mar 25, 2024

1tnguyen commented Mar 25, 2024 • edited by github-actions bot Loading

github-actions bot commented Mar 25, 2024

1tnguyen commented Mar 25, 2024 • edited by github-actions bot Loading

github-actions bot commented Mar 25, 2024

1tnguyen commented Mar 25, 2024 • edited by github-actions bot Loading

github-actions bot commented Mar 26, 2024

1tnguyen commented Mar 27, 2024 • edited by github-actions bot Loading

github-actions bot commented Mar 27, 2024

1tnguyen commented Mar 27, 2024 • edited by github-actions bot Loading

github-actions bot commented Mar 27, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

1tnguyen commented Apr 12, 2024 • edited by github-actions bot Loading

github-actions bot commented Apr 12, 2024

1tnguyen commented Apr 12, 2024 • edited by github-actions bot Loading

github-actions bot commented Apr 12, 2024

1tnguyen commented Apr 12, 2024 • edited by github-actions bot Loading

github-actions bot commented Apr 13, 2024

1tnguyen commented Apr 16, 2024 • edited by github-actions bot Loading

1tnguyen commented Apr 17, 2024 • edited by github-actions bot Loading

github-actions bot commented Apr 17, 2024

bmhowe23 Apr 17, 2024

Choose a reason for hiding this comment

1tnguyen Apr 17, 2024

Choose a reason for hiding this comment

1tnguyen commented Mar 22, 2024 •

edited

Loading

1tnguyen commented Mar 24, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Mar 25, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Mar 25, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Mar 25, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Mar 27, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Mar 27, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Apr 12, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Apr 12, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Apr 12, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Apr 16, 2024 •

edited by github-actions bot

Loading

1tnguyen commented Apr 17, 2024 •

edited by github-actions bot

Loading