Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with cnot operation not being properly compiled for some targets #1466

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

schweitzpgi
Copy link
Collaborator

Although the control shorthands were being recognized in the bridge, they were inadverently being promoted to non-control forms of the same quantum gate.

Fixes #1464.

Description

Although the control shorthands were being recognized in the bridge,
they were inadverently being promoted to non-control forms of the same
quantum gate.

Fixes NVIDIA#1464.
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

github-actions bot commented Apr 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schweitzpgi schweitzpgi merged commit 8174e14 into NVIDIA:main Apr 2, 2024
125 checks passed
@schweitzpgi schweitzpgi deleted the ch-i1464 branch April 2, 2024 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
@bettinaheim bettinaheim changed the title Fix #1464: control setting was being dropped. Fix issue with cnot operation not being properly compiled for some targets Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cnot operation is not compiled properly in MLIR mode
4 participants