Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating branch with latest from main #992

Merged

Conversation

bettinaheim
Copy link
Collaborator

No description provided.

schweitzpgi and others added 9 commits November 28, 2023 16:50
* Simplify lambda expressions.

These changes simplify some of the lambda expressions in the cudaq
headers. It eliminates some of the more complicated capture expressions
and uses simple reference capture. It also removes the `mutable`
modifier which does not appear to be necessary in these cases.

* Revert some of the changes. It looks like there is a bug in GCC 12 that
is resulting in a test failure in qpp_AsyncTester.checkSampleAsync when
building Debug mode. I've tried multiple ways of writing the lambdas in
question, which are surprisingly fairly simple, without success.
** Description: Some Python backend tests fail by reporting custatevec errors when running on a machine with GPUs
** Fix:
  -- Set the target in test fixture that starts mock server
  -- Wrap the call to 'cudaGetDevice' in CUDA error handler for early catching
* getting rid of cmake warnings

* input documentation for dev_environment.yml

* undoing edits that are in a separate PR
* Fixed for tensornet backend may not pick up MPI

The tensornet backend propagates MPI to cutensornet during ctor. However,
the static instance might be created before MPI initialization; hence
need to be reset to pick up MPI and propagate to cutensornet.

* Fix EOF

* Update runtime/nvqir/cutensornet/simulator_tensornet_register.cpp

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

---------

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@bettinaheim bettinaheim merged commit c8060db into NVIDIA:experimental/python Dec 1, 2023
23 checks passed
@bettinaheim bettinaheim deleted the experimental/python branch December 1, 2023 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants