Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set missing defaults in playbooks #1134

Merged
merged 6 commits into from Mar 23, 2022
Merged

Conversation

dholt
Copy link
Contributor

@dholt dholt commented Mar 23, 2022

Found a couple of playbooks that use variables without setting defaults

Also cleaned up a redundant Chrony task

@@ -6,6 +6,3 @@
- name: Configure Chrony client
include_role:
name: DeepOps.chrony

- name: Set timezone
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work happen in the role now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like yes.

Copy link
Collaborator

@supertetelman supertetelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean changes all around.

@supertetelman supertetelman merged commit 4345854 into NVIDIA:master Mar 23, 2022
@ajdecon ajdecon mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants