Grafana: add var for custom config template #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ------- Currently we use a hard-coded template for `grafana.ini`, but this file is frequently customized by users to specify things like email servers. This PR adds an Ansible var to allow the source of this template to be specified by the user. Addresses NVIDIA#977. Test plan --------- Passing CI tests.
michael-balint
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we use a hard-coded template for
grafana.ini, but this fileis frequently customized by users to specify things like email servers.
This PR adds an Ansible var to allow the source of this template to be
specified by the user.
Addresses #977.
Test plan
Passing CI tests.