Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong destruction order for event queue #79

Merged
merged 1 commit into from Apr 19, 2023
Merged

Conversation

q234rty
Copy link
Contributor

@q234rty q234rty commented Apr 7, 2023

libwayland 1.22 added a warning that could currently be triggered by running eglgears_wayland under NVIDIA wayland:

warning: queue 0x5560c4ce1b30 destroyed while proxies still attached:
  wl_registry@3 still attached

Firefox currently crashes upon such warnings. Mesa has fixed a similar bug in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21646

@AlynxZhou
Copy link

I tested this with a NVIDIA 2070 Super using nvidia driver, it fixes the warning.

@colemickens
Copy link

Ping, if this can be merged/tagged it would be great. It's currently potentially blocking distro(s) that want to update libwayland.

@erik-kz
Copy link
Collaborator

erik-kz commented Apr 17, 2023

Thanks. This looks good to me. Will merge after getting +1 from another NVIDIA engineer.

@erik-kz erik-kz merged commit 13737c6 into NVIDIA:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants