Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix issue 244] fix bug in gdr_generate_mr_handle #248

Merged
merged 2 commits into from
May 9, 2023
Merged

[Fix issue 244] fix bug in gdr_generate_mr_handle #248

merged 2 commits into from
May 9, 2023

Conversation

pakmarkthub
Copy link
Collaborator

@pakmarkthub pakmarkthub commented Mar 6, 2023 •
edited by drossetti

Issue:

This PR:

  • introduces basic_small_buffers_mapping unit test in sanity.
  • fixes bug in gdr_generate_mr_handle.
  • bonus: fixes gdrdrv/Makefile to detect changes in gdrdrv.c.

Presubmit testing:

  • locally on gc11 (x86).

drossetti
drossetti requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@drossetti drossetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit

src/gdrdrv/Makefile Outdated Show resolved Hide resolved
@pakmarkthub pakmarkthub requested a review from drossetti May 9, 2023 03:53
drossetti
drossetti approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@drossetti drossetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@drossetti drossetti merged commit cd5b6b3 into NVIDIA:master May 9, 2023
@tylerjereddy tylerjereddy mentioned this pull request May 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drossetti drossetti drossetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gdrdrv returns the same handle for two pinned buffers
2 participants
@pakmarkthub @drossetti