Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report when attempting to copy files to a temporary directory when using Singularity #353

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

samcmill
Copy link
Collaborator

@samcmill samcmill commented Mar 26, 2021

Pull Request Description

Partially address #345.

If a recipe stages a file into a container using /tmp or /var/tmp, issue an error if the Singularity version >= 3.6, otherwise a warning. The message describes possible mitigation steps.

A full solution would likely mean changing the default working directory from /var/tmp to another location. Possible candidates include /opt or /var/cache. But that's a bigger change with potential side effects.

Author Checklist

  • Updated documentation (pydocmd generate) if any docstrings have been modified
  • Passes all unit tests

@samcmill samcmill merged commit edecbd9 into master Mar 26, 2021
@samcmill samcmill deleted the singularity-tmp-staging branch March 26, 2021 17:21
gonzalobg pushed a commit to gonzalobg/hpc-container-maker that referenced this pull request May 13, 2021
gonzalobg pushed a commit to gonzalobg/hpc-container-maker that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant