Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add topology field for nvidia device plugin #127

Closed
wants to merge 2 commits into from
Closed

add topology field for nvidia device plugin #127

wants to merge 2 commits into from

Conversation

carmark
Copy link
Contributor

@carmark carmark commented Jul 26, 2019

@bg-chun bg-chun mentioned this pull request Sep 26, 2019
Closed
11 tasks
klueska
klueska reviewed Sep 26, 2019
View reviewed changes
nvidia.go Outdated
@@ -29,6 +29,11 @@ func getDevices() []*pluginapi.Device {
devs = append(devs, &pluginapi.Device{
ID: d.UUID,
Health: pluginapi.Healthy,
Topology: &pluginapi.TopologyInfo{
Node: &pluginapi.NUMANode{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Would you mind updating this to the newest API interface?

kubernetes/kubernetes@1c1f19c#diff-45056b94548d2ceef7f0d1028f937a05L77

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@carmark carmark force-pushed the socket branch 2 times, most recently from 7835e65 to 9f52665 Compare September 27, 2019 03:43
@carmark carmark changed the title WIP: add topology field for nvidia device plugin add topology field for nvidia device plugin Sep 27, 2019
@klueska
Copy link
Contributor

klueska commented Sep 27, 2019

The change to add the Topology field looks OK to me, but I'm not 100% sure about the vendoring update.

/cc @RenaudWasTaken can you please take a look and verify that the vendoring patch

@RenaudWasTaken
Copy link
Contributor

Hello!

Can you move your PR to : https://gitlab.com/nvidia/kubernetes/device-plugin
The code is now hosted there and mirrored to github!

@RenaudWasTaken
Copy link
Contributor

Also it looks like you haven't signed-off your commits, do you mind taking care of it?
https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

Thanks a lot!

@RenaudWasTaken
Copy link
Contributor

Note that the project was just relicensed to apache2: https://github.com/NVIDIA/k8s-device-plugin/blob/master/CONTRIBUTING.md

@carmark
Copy link
Contributor Author

carmark commented Oct 1, 2019

@RenaudWasTaken sure, no problem.

@carmark
Copy link
Contributor Author

carmark commented Oct 4, 2019

close, since cc0aad8

@carmark carmark closed this Oct 4, 2019
@am0ral93 am0ral93 mentioned this pull request Jun 8, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carmark @klueska @RenaudWasTaken