Fixing allPossibleMigStrategiesAreNone helm chart helper. #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubkrzykowski
force-pushed
the
fix-all-mig-strategies-are-none
branch
from
0e6b4c5
to
881e398
Compare
elezar
reviewed
May 23, 2024
| @@ -130,7 +130,7 @@ Check if migStrategy (from all possible configurations) is "none" | |||
| {{- if ne .Values.migStrategy "none" -}} | |||
| {{- $result = false -}} | |||
| {{- end -}} | |||
| {{- else if ne (include "nvidia-device-plugin.configMapName" .) "true" -}} | |||
| {{- else if ne (include "nvidia-device-plugin.configMapName" .) "" -}} | |||
There was a problem hiding this comment.
Question: Would it not be better to use nvidia-device-plugin.hasConfigMap here?
(Looking at #689 I would assume that that may also need to be updated in some way though).
elezar
requested changes
May 31, 2024
Signed-off-by: Jakub Krzykowski <jakub@krzykowski.it>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
fix-all-mig-strategies-are-none
branch
from
881e398
to
8e36e36
Compare
elezar
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Thanks @jakubkrzykowski. These look good now.
I rebased and incorporated the changes from #749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configMapNameis the empty string""by default and it breaksallPossibleMigStrategiesAreNonefunction with default values.See #670 for details.