Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix missing include in limits when using NVRTC #14

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

benbarsdell
Copy link
Member

@benbarsdell benbarsdell commented Sep 21, 2020

This is required to provide the definitions of __CHAR_BIT__, __FLT_MANT_DIG__ etc.

- This is required to provide the definitions of __CHAR_BIT__,
  __FLT_MANT_DIG__ etc.
@brycelelbach
Copy link
Collaborator

@griwes shouldn't QA have caught this? Do we have rest coverage for this?

@griwes
Copy link
Collaborator

griwes commented Sep 21, 2020

We have not done any QA on <limits>, we haven't put it on the list of officially supported headers yet, because there's been more effort involved in making the tests work than we had time when shipping what needed some of the functions from it. I think that Wesley encountered one of the things I did in those tests in the tests for tuple and figured out a way to make it work without too much effort, so we should probably do that at this point.

@brycelelbach brycelelbach added this to the 1.3.0 milestone Sep 28, 2020
@brycelelbach
Copy link
Collaborator

@griwes what are we doing with this PR, it's marked 1.3.0. Is it tested? Is it shipping?

@brycelelbach brycelelbach modified the milestones: 1.3.0, 1.3.1 Oct 3, 2020
@griwes
Copy link
Collaborator

griwes commented Oct 3, 2020

If it fixes the described problem then we should probably just ship it. I expect that something similar is what would ultimately need to be done when we start QAing limits. This passes an NVRTC run, so should be fine.

@brycelelbach
Copy link
Collaborator

@griwes can we merge this?

@brycelelbach brycelelbach merged commit 7ff2a83 into NVIDIA:main Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants