This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix host only compilation of <cuda/std/cmath> #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
force-pushed
the
bugfix/cmath_host_only
branch
from
f3b36b9
to
ef7458c
Compare
griwes
approved these changes
Feb 11, 2022
| @@ -792,6 +792,11 @@ typedef __char32_t char32_t; | |||
| #define _LIBCUDACXX_HAS_NO_ASAN | |||
| #endif | |||
|
|
|||
| // GCC implemented P0030R1 in 7.0, maybe only available under experimental? | |||
| #if _GNUC_VER < 700 | |||
| #define _LIBCUDACXX_NO_HOST_CPP17_HYPOT | |||
There was a problem hiding this comment.
I can see a use of this in cmath that's being removed in this PR. Is this still needed?
The __cuda_std__ guard is sufficient.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set fixes compilation on clang and gcc. Currently there are missing/extra definitions caused by nvcc including math.h by default.
VDVS: https://builds4u.nvidia.com/dvs/#/change/3067999458696529.1?eventType=Virtual&dvs_showStaging=on