This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Soundness bugfix for barrier<thread_scope_block> on sm_70 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniellustig could maybe review? |
griwes
reviewed
Aug 10, 2022
| unsigned int __active = __activeA & __activeB; | ||
| int __inc = __popc(__active) * __update; | ||
|
|
||
| unsigned __laneid; | ||
| asm volatile ("mov.u32 %0, %laneid;" : "=r"(__laneid)); | ||
| asm ("mov.u32 %0, %laneid;" : "=r"(__laneid)); |
There was a problem hiding this comment.
Why are you removing the volatile here?
There was a problem hiding this comment.
Because it is not necessary. Two "calls" to this assembly instruction from this same thread always "return" the same value, so eliding one is a valid transformation for the compiler to do.
This assembly statement does not modify any memory, so it does not need a "memory" clobber either.
|
The cumulativity fix seems reasonable to me |
|
@wmaxey ? |
davedsth
approved these changes
Sep 14, 2022
|
Thanks for review, David. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sm_70, barrier arrive has an optimization to "coalesce" all arrives with the same update to the same barrier into a single update performed by a "leader" thread.
This optimization is missing a release fence to establish cummulativity between all coalesced threads and the leader, before the leader performs the update.