This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix proclaim_return_type copy constructor #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Mar 9, 2023
jrhemstad
approved these changes
Mar 9, 2023
|
@wmaxey Ideally we should get this into 2.1. As more people start using Thrust from CUDA 12, they are going to run into the error from using |
gevtushenko
force-pushed
the
fix-main/github/proclaim_return_type_copy_constructor
branch
from
1423def
to
e52c6ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no way to use
cuda::proclaim_return_typebecause we can't copy it. This PR SFINAE out template copy constructor and adds a default one to address the issue.