Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Configurable page size on aarch64 #132

Closed
kwizart opened this issue Aug 23, 2017 · 3 comments
Closed

[RFE] Configurable page size on aarch64 #132

kwizart opened this issue Aug 23, 2017 · 3 comments

Comments

@kwizart
Copy link
Contributor

kwizart commented Aug 23, 2017

Fedora kernel uses a CONFIG_ARM64_4K_PAGES=y by default
Since commit cfce0c8 the default is now 64K, so I wonder if it would be better to make a configure option instead ?

@kbrenneman
Copy link
Collaborator

It would be better, and I made sure to set it up so that you could override it from the configure script. I just haven't gotten a chance to implement that yet.

Basically, the configure script just needs to get the value of sysconf(_SC_PAGESIZE), then plug that into an AC_DEFINE.

@aaronp24
Copy link
Member

What happens if a binary built on one kernel runs on one with a different page size? Can this be handled at runtime or would that be bad for performance?

@kbrenneman
Copy link
Collaborator

At that point, you'd lose the entrypoint patching functionality, because it wouldn't be able to call mprotect on the statically defined dispatch stubs.

The performance impact from that depends on whether a vendor library actually uses entrypoint patching, and how much a given application would benefit from it.

As far as I know, though, no existing driver uses entrypoint patching for aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants