Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA: Support for cos zenith angle in the ERA5 HDF5 dataloader #528

Merged
merged 4 commits into from
May 29, 2024

Conversation

mnabian
Copy link
Collaborator

@mnabian mnabian commented May 24, 2024

Modulus Pull Request

Description

Closes #527

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@mnabian
Copy link
Collaborator Author

mnabian commented May 24, 2024

/blossom-ci

@mnabian mnabian self-assigned this May 24, 2024
@mnabian
Copy link
Collaborator Author

mnabian commented May 29, 2024

@dallasfoster @loliverhennigh here's a comparison between the outputs of the two routines for zenith angle (np.max(z, 0)-1/pi) for '1983-10-19 06:00:00'. They don't match exactly.

legacy
test
test

@mnabian
Copy link
Collaborator Author

mnabian commented May 29, 2024

Reverting this change brings the two much closer, but there is still a small discrepancy

legacy
test
diff

@dallasfoster
Copy link
Collaborator

Reverting this change brings the two much closer, but there is still a small discrepancy

Reverting this change makes the following two methods: datapipes/climate/utils/zenith_angle::_days_from_2000 and modulus/utils/zenith_angle::_days_from_2000 consistent.

@dallasfoster
Copy link
Collaborator

After reviewing each cos_zenith_angle code I am fairly confident that, after reverting the aforementioned change, the two codes are sufficiently equivalent.

@mnabian
Copy link
Collaborator Author

mnabian commented May 29, 2024

/blossom-ci

@mnabian mnabian merged commit a8a20bd into NVIDIA:main May 29, 2024
1 check passed
@mnabian mnabian deleted the fea-ext-datapipe_cos_zenith branch May 29, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀[FEA]: Add support for cos zenith angle in the ERA5 HDF5 dataloader
4 participants