Improve warning message about truncated messages #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display hints of cause so that it would be easier for user to debug. Also change the error type from InternalError to InvalidUsage as most of time this is caused by a mismatch in collective size or env settings.
|
Thanks for the PR. I can agree with the intent but shouldn't we do the same for IB, and split the tests here in two parts, and return invalid usage for the first check ( |
First part on collective mismatch, second part on internal errors
|
Sylvain, that's a great idea, thanks! I added a commit to implement what you refer to. |
|
Hi @sjeaugey @AddyLaddy @jbachan , I was wondering if you have more comments about this PR. We recently observed more incidents where these paths got hit -- both the socket one and the IB one. It would be great if we could use a different code than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "truncated message" error is most often triggered by a mismatch in collective size or env settings between ranks.
For better interpretability, the patch displays hints of cause so that it would be easier for user to debug.
It also changes the error type from InternalError to InvalidUsage to reflect the above most-likely causes.